Removed considerations for Windows 95/98/ME #2400
Open
+46
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
force-pushed
the
Remove-Windows-95-98-ME
branch
from
c06e77c
to
2935175
Compare
Avasam
commented
Oct 13, 2024
Comment on lines
43
to
48
| // Global\\ etc goodness: | ||
| // On NT4/9x, 'Global\\' is not understood and will fail. | ||
| // On 2k/XP, anyone can create 'global' objects. | ||
| // On Vista, you need elavated perms to create global objects - however, once | ||
| // On Vista, you need elevated perms to create global objects - however, once | ||
| // it has been created and permissions adjusted, a user with normal | ||
| // permissions can open these global objects. |
Avasam
commented
Oct 13, 2024
Comment on lines
+168
to
+169
| // Do a LoadLibrary, as the Ex version may not always exist on Win95. | ||
| // TODO: We no longer support Windows 95, how should this code be updated ? |
There was a problem hiding this comment.
We no longer support Windows 95, how should this code be updated ?
Avasam
commented
Oct 13, 2024
Comment on lines
+66
to
+68
| # in order to *use* the username/password of a particular dun entry, | ||
| # one must explicitly get those params under Win95 ... | ||
| # TODO: We no longer support Windows 95, how should this code be updated ? |
There was a problem hiding this comment.
We no longer support Windows 95, how should this code be updated ?
Avasam
commented
Oct 13, 2024
Comment on lines
+257
to
-258
| | win32con.MIIM_TYPE | ||
| ) | ||
| # Note: No MIIM_TYPE - this screws win2k/98. |
There was a problem hiding this comment.
This needs to be tested, I have no idea of its actual effect. Just following the comment.
Avasam
commented
Oct 13, 2024
Comment on lines
+107
to
+109
| // On platforms that don't have NT security, | ||
| // the initialization of the SECURITY_DESCRIPTOR should fail, | ||
| // leaving the sd NULL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review this carefully, I'm a bit out of my depth in certain places and am left guessing. I've left GitHub comments on specific files.